Closed AlexTheWizardL closed 6 days ago
I've tested the logic for the LedgerCSVDataFrameEntity
modify()
method and it is working. Here is why:
_store
method.pd.concat()
- that is true, but then our write_ledger_file()
method within the TextLedger sorts rows by id numeric part. Done along this line: df = df.iloc[self.ledger._id_from_path(df["id"]).argsort(kind="mergesort")]
I removed that line for sorting and now the test catches the problem. It is shown in this failed test actionWhat it means:
test_ledger_mutators_does_not_change_order()
test is not broken.
The logic implemented for the
modify()
method withinLedgerCSVDataFrameEntity
class in the loop does not work for making multiple modifications at once within the same file.This means we have two problems:
Please address both points in the following sequence: