search

maczokni / crimemapping_textbook_bookdown

Workbook for crime mapping course
Creative Commons Zero v1.0 Universal
29 stars 6 forks source link

Wk7: wrong order of commands? #13

Open mbroedl opened 5 years ago

mbroedl commented 5 years ago

https://github.com/maczokni/crimemapping_textbook_bookdown/blob/85b5c56223ba87ba3260edc2daacce7f3bda9347/07-week7.Rmd#L175

This line caused issues in the tutorial because bur_ccsp only has $code but not $lsoa_code. That one is created a few lines earlier but on a different variable. I suggest putting line 166 before 159.

https://github.com/maczokni/crimemapping_textbook_bookdown/blob/85b5c56223ba87ba3260edc2daacce7f3bda9347/07-week7.Rmd#L159 https://github.com/maczokni/crimemapping_textbook_bookdown/blob/85b5c56223ba87ba3260edc2daacce7f3bda9347/07-week7.Rmd#L166

mbroedl commented 5 years ago

NB: I was just told by a student that data_frame here throws a warning and should be replaced with tibble: https://github.com/maczokni/crimemapping_textbook_bookdown/blob/85b5c56223ba87ba3260edc2daacce7f3bda9347/07-week7.Rmd#L432