mad-eye / meteor-mocha-web

easily and safely run mocha tests within the Meteor framework
MIT License
145 stars 46 forks source link

Fix a variable access issue when velocity is not enabled(velocity=0) #186

Closed serut closed 8 years ago

serut commented 9 years ago

I don't know how to add this pull request to the last one (if it's possible) so I created a new one. Thanks,

serut commented 8 years ago

This issue is still persisting, can you please accept this pull request ? It happens when you run a project with VELOCITY=0 error-package-mad-eye

firrae commented 8 years ago

We just ran into this exact same issue, is there an ETA on when this might be pulled in so we can update?

davidworkman9 commented 8 years ago

@rissem +1

firrae commented 8 years ago

Thank you @rissem

davidworkman9 commented 8 years ago

Can you push this to atmosphere please?

firrae commented 8 years ago

+1 @rissem, doesn't seem it was updated on Atmosphere.

serut commented 8 years ago

@rissem, can you update the version of this package from 0.6.5 to 0.6.6 to let us get the fix ?

rissem commented 8 years ago

Published to atmosphere now. Thanks for letting me know it was unpublished.

firrae commented 8 years ago

Thanks a bunch @serut and @rissem, this seems to have solved my problem!