mad-lab-fau / gaitmap

The Gait and Movement Analysis Package
https://gaitmap.readthedocs.io
Other
38 stars 2 forks source link

Tests fail if pomegrenate not installed #31

Closed MalteOlle closed 1 year ago

MalteOlle commented 1 year ago

Steps to reproduce:

  1. clone repository
  2. poetry install
  3. poetry run poe test

Result:

poetry run poe test
Poe => pytest --cov=gaitmap --cov=gaitmap_mad --cov-report=term-missing --cov-report=xml
ImportError while loading conftest '.../gaitmap/tests/conftest.py'.
tests\conftest.py:9: in <module>
    from pomegranate import GeneralMixtureModel, State
E   ModuleNotFoundError: No module named 'pomegranate'

Expected Result: Should work...

Suggestion:

MalteOlle commented 1 year ago

@AKuederle add this to the public release milestone?

AKuederle commented 1 year ago

Fixed by https://github.com/mad-lab-fau/gaitmap/commit/170be937230d5af8dd5ad5b7201baee0371a65ef

Will likely be something that can reoccure, if people forget to add the correct skip, but not a big deal. Will handle it again, if people run into that issue.