search

mad-lab-fau / gaitmap

The Gait and Movement Analysis Package
https://gaitmap.readthedocs.io
Other
38 stars 2 forks source link

Adding the range of motion (max. orientation change) to the list of spatial parameters. #54

Closed AKuederle closed 4 months ago

AKuederle commented 6 months ago

@HaMora Any updates on this?

HaMora commented 5 months ago

Hi @AKuederle, Can we have a short talk about this next week? I really wanna know the underlying work for the tests and the snapshots that we have. As far as I understand, the test fails since we need a new snapshot with the new parameter. Which, honestly; I didn't spend much time as well to figure out how to create them :)

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.58%. Comparing base (b7139d9) to head (6bd7a86).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #54 +/- ## ========================================== + Coverage 91.56% 91.58% +0.01% ========================================== Files 61 61 Lines 3297 3303 +6 ========================================== + Hits 3019 3025 +6 Misses 278 278 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HaMora commented 4 months ago

Hi @AKuederle, I have fixed the tests and replaced the snapshots (thank you for the explanations). I just don't know why the docs test failed.