madMAx43v3r / chia-plotter

Apache License 2.0
2.28k stars 665 forks source link

Build Warning #525

Open whitetechnologies opened 3 years ago

whitetechnologies commented 3 years ago

This is a build error that allows build to continue (non fatal) but should be addressed for cleaner code. Appears at the end of build in "built target test_phase_2"

Built target test_phase_2 In file included from /home//chia-plotter/lib/bls-signatures/src/elements.hpp:22, from /home//chia-plotter/lib/bls-signatures/src/privatekey.hpp:24, from /home//chia-plotter/lib/bls-signatures/src/bls.hpp:18, from /home//chia-plotter/src/chia_plot.cpp:15: /home//chia-plotter/lib/bls-signatures/src/util.hpp: In static member function ‘static std::string bls::Util::HexStr(const uint8_t*, size_t)’: /home//chia-plotter/lib/bls-signatures/src/util.hpp:62:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] 62 | for (int i=0; i < len; ++i) | ^~~ /home//chia-plotter/lib/bls-signatures/src/util.hpp: In static member function ‘static std::string bls::Util::HexStr(const std::vector&)’: /home//chia-plotter/lib/bls-signatures/src/util.hpp:70:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘std::vector::size_type’ {aka ‘long unsigned int’} [-Wsign-compare] 70 | for (int i=0; i < data.size(); ++i) | ^~~

SebMoore commented 3 years ago

This code comes from the bls-signatures library, meaning it isn't code from this plotter. It was written by the Chia team! So if you want to fix it, go ask them.