search

madalinoprea / magneto-debug

Magento Developer Toolbar
http://www.moprea.ro/
MIT License
355 stars 121 forks source link

Overwriting `core_email` and `core_email_template` gives conflicts #77

Open sandermangel opened 8 years ago

sandermangel commented 8 years ago

A few frequently used email modules like Ashroder_Smtp, mailchimp and dotmailer rewrite the core_email and core_email_template models.

Is there any other way to do the profiling on emails than a rewrite or maybe make it optional?

https://github.com/madalinoprea/magneto-debug/blob/master/code/Debug/etc/config.xml#L27

madalinoprea commented 8 years ago

Hi @sandermangel,

I'm going to think about it. I agree that this extension shouldn't have this side effect.

Currently I'm going to see if we can apply this solution https://github.com/Danack/intahwebz-examples/tree/master/src/Intahwebz/Examples/DynamicInheritance

Or add the rewrites dynamically only if we can handle core/email_template implementation.

sandermangel commented 8 years ago

Great! Thanks for that. Looks like a nice option to fix the issue

sandermangel commented 8 years ago

@madalinoprea wasn't this fixed in the latest version?