search

madalinungureanu / user-profile-picture

WordPress User Profile Picture
GNU General Public License v2.0
15 stars 7 forks source link

Visual Bugfixes and Nonexistant Default Image Fix #4

Closed Kelderic closed 8 years ago

Kelderic commented 8 years ago

Per discussion in support thread here:

https://wordpress.org/support/topic/visual-bug-and-fix?replies=7

(This is my first attempt at forking and submitting a pull request, so please let me know if I screwed anything up)

ronalfy commented 8 years ago

Thanks for the PR! I'll take a look at it this evening.

ronalfy commented 8 years ago

@Monter @Kelderic All issues should be resolved in this PR. https://github.com/ronalfy/user-profile-picture/pull/6

Kelderic commented 8 years ago

Tested and looks good. Also I need to apologize, I realized another plugin was causing some interference. With it disabled, problems are greatly reduced.

The only thing I see with #6 is that the selected image isn't moved to first spot, which was @Monter's concern:

pr6

ronalfy commented 8 years ago

I'm okay with that. It works that way for regular post featured images also.

Kelderic commented 8 years ago

True. Which then makes this the exact same in behavior to my second pull request. We are just using the fact that using the predefined Featured Image state already does the initial selection for us. The media uploader JS is one of the most complicated pieces of JS that I've ever worked with. I gave up trying to find the featured image controller definition, to figure out how it is doing the initial selection.

Monter commented 6 years ago

Hello again, There is still something wrong. When you select an image you uploaded a long time ago in the gallery much lower, indicating the image no longer works (pointing to the file until the profile/settings are saved).