search

madand / pentadactyl-pm

Pentadactyl for Pale Moon | New official repo is here https://github.com/pentadactyl/pentadactyl
Other
26 stars 4 forks source link

Works with PM28+, but no help files #9

Open zenny opened 5 years ago

zenny commented 5 years ago

Thanks to @jackrosenthal https://github.com/jackrosenthal/pentadactyl-pm for posting the repo as stated in https://github.com/madand/pentadactyl-pm/issues/7

However, no help files works as all pages at dactyle://intro/help point to an invalid address! Hmmm...

Where are the help files?

Cheers, /z

jackrosenthal commented 5 years ago

Looks like the underlying issue is with RedirectChannel in common/modules/protocol.jsm. The browser is not following the meta-header redirect...

Might be able to make a fix.

zenny commented 5 years ago

@jackrosenthal Thanks for the quick fix. Howver, after updating to https://github.com/jackrosenthal/pentadactyl-pm/commit/0a05e0089be4d823ac21fa77869b8fb69fd77eb2 disables not only navigation, but stops working other commands!

jackrosenthal commented 5 years ago

Odd... I did not see this on my end. Running PM 28.5 on Linux (X11).

Perhaps try uninstall/reinstall the extension?

zenny commented 5 years ago

@jackrosenthal Thanks, but uninstalling and installing didn't work at my end. scrolling with h/j/k/l or with PgDown/Up/Home/End and arrows do not work in my case. Pressing those keys outputs:

resource://dactyle/buffer.jsm: 1742: Typeerror: option is undefined

I am also running the 28.5 like yours in Linux (X11), fyi. Cheers,

jackrosenthal commented 5 years ago

Looked again and I am seeing the issue ... odd. No idea why this change would cause that.

I'll look at it further this week as time permits.

Jack

jackrosenthal commented 5 years ago

This is solved in the latest patch in the new community repo:

https://github.com/pentadactyl/pentadactyl