The pull request focuses on adding and refining unit tests across primitives and client/sync modules.
Pull Request type
Testing
What is the current behavior?
What is the new behavior?
the sync process from FGW now directly transforms state updates into our primitive types instead of passing through starknet-cors’s intermediate types
removing the ToStateUpdateCore trait by directly implementing the From trait instead
adding unit tests across all crates of primitives:
block header
block inner
class
receipt
state update
transaction
The conversion between starknet-api transaction and our own transaction type has been updated. Previously, we used a reference . However, the new implementation now takes ownership of the Transaction instead of borrowing it. This change was made because the starknet-api now uses Felt as the primitive type for transactions. By taking ownership, it avoids unnecessary copies of Felt and reduces the need for iterations over vectors during the conversion process.
Does this introduce a breaking change?
No
Other information
our unit tests are currently being conducted on inconsistent data, I’ve opened #230 to address the issue
The pull request focuses on adding and refining unit tests across primitives and client/sync modules.
Pull Request type
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
No
Other information
our unit tests are currently being conducted on inconsistent data, I’ve opened #230 to address the issue