madara-alliance / madara

Madara is a powerful hybrid Starknet client written in Rust.

https://madara.build

Apache License 2.0

77 stars 30 forks source link

dev: Block import refactoring #237

Closed akhercha closed 2 months ago

akhercha commented 2 months ago

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

Refactoring (no functional changes, no API changes)

What is the current behavior?

Resolves: #NA

What is the new behavior?

Added

Validate trait implementation for UnverifiedPendingFullBlock and UnverifiedFullBlock
tx_batch_size as CLI parameter

Updated

types of block_import moved to primitives,
rayon pool moved to primitives

Not so sure about

new block primitives - if they'll be used only in the block_import crate, should they live there? If we're gonna use them elsewhere it should be fine in primitives.
compute_merkle_root & transaction_hashes + TransactionHashesError are currently in primitives/block/src/lib.rs. Where should they live?

Any thoughts? @cchudant

akhercha commented 2 months ago

PR closed as the changes don't have unanimous approval. We'll keep the refactor for later and if the validate trait is necessary for tests, we'll re-implement it in the associated PRs.