search

madari / go-socket.io

A Socket.IO backend implementation written in Go
http://gopkgdoc.appspot.com/pkg/github.com/madari/go-socket.io
MIT License
412 stars 64 forks source link

Tip make go1 compatible #17

Closed nightlyone closed 11 years ago

nightlyone commented 12 years ago

Hi Jukka,

I did the minimal changes to make your nice go-socket.io package compatible with Go 1.0.x. It compiles and all unit tests run.

Please review the error handling around syscall.EAGAIN. I guess this needs to be reworked a little.

The example works for me, after changing the importing socketio like this socketio "github.com/nightlyone/go-socket.io"

I guess you wanna change this to "github.com/madari/go-socket.io" after the pull.

Thanks for your consideration.

Best Regards

Ingo Oeser, aka nightlyone

c9s commented 11 years ago

Hi Jukka

Please please merge this change, which is a critical bug for new go. (can't install)

c9s commented 11 years ago

Is this a private fork? I can't pull down these changes.

rjmcguire commented 11 years ago

I use go-socketio on Google code. Works for more recent socketio js library. On 29 Nov 2012 06:39, "Yo-An Lin" notifications@github.com wrote:

Is this a private fork? I can't pull down these changes.

— Reply to this email directly or view it on GitHubhttps://github.com/madari/go-socket.io/pull/17#issuecomment-10834969.

nightlyone commented 11 years ago

@c9s I deleted my fork of the repository, because I just fixed it for fun, my pull request got ignored for 5 months and later found out that lots of people fixed the same stuff in their own forks and even fixed some bugs.

Best version of this library is at https://github.com/davies/go-socket.io