search

madari / go-socket.io

A Socket.IO backend implementation written in Go
http://gopkgdoc.appspot.com/pkg/github.com/madari/go-socket.io
MIT License
412 stars 64 forks source link

Patches justinfx #6

Closed justinfx closed 13 years ago

justinfx commented 13 years ago

Done a number of things to the library:

Memory Fixes: *There were some areas in the codecs where buffers were not being reset and memory kept growing. Changes some areas to use []byte instead of string. I still think there might be some memory leaks, but it requires more testing. I think memory will continue to grow as you pound the server with many connections sending many message. But its less a problem now that it was before

Heartbeats:

Authorization:

madari commented 13 years ago

Wow, that's a lot of code - thank you. I'll let you know when I've read it all!

madari commented 13 years ago

Can you please extract the message/codec changes into a separate pull request and do the same for the authorization part. Those two seem pretty ready to be merged right away!

I'd like to think about the heartbeat-problem a little more and do some testing. Can you put the test-client you used to reproduce the heartbeat-problems with somewhere so I could have a look? Or can you come up with some other way to reproduce it?

justinfx commented 13 years ago

Gunna close this one as I have split the codec/message and authorization fixes into seperate pull reqs. Excluding the heartbeat stuff for now since you want to think about it.