madbag
commented
1 year ago Thank you, Agustina for such detailed feedback. I will work on my shortcomings.
Open p-agustina opened 1 year ago
madbag
commented
1 year ago Thank you, Agustina for such detailed feedback. I will work on my shortcomings.
p-agustina
commented
1 year ago It's already a super nice project 😉
It'll be available at the end of the month, not sure if it will be free but if so, nice a project after the bootcamp, once you are an expert on APIs use hihi.
On Thu, 7 Sept 2023 at 13:38, Madhushree @.***> wrote:
Thank you, Agustina for such detailed feedback. I will work on my shortcomings.
— Reply to this email directly, view it on GitHub https://github.com/madbag/fight-the-fire/issues/1#issuecomment-1710080446, or unsubscribe https://github.com/notifications/unsubscribe-auth/A46TK77T3PEURA7ACJ4ZCLDXZG54PANCNFSM6AAAAAA4FUHSAY . You are receiving this because you authored the thread.Message ID: @.***>
madbag
commented
1 year ago Whoa! This is super awesome to know Google is working on it. Thank you for the share Agustina! <3
Hi Maddy!
I wanted to share some feedback on your project, Fight the fire. First off, congrats on nailing the first project of the bootcamp!
The first thing that I can see when I open your repository is the very well organized folder structure you've set up. It makes navigating through your code super easy – good job on that! Well job also on your GitHub use throughout the project, it’s a good coding practice to commit your work regularly, as you did.
I like both your start and end of the game screens, it makes for a good user experience. I specifically liked how you shared resources to contribute in real life through technology, it’s a nice touch.
While your work is already good, I have a few suggestions that might polish it even more:
Your README file could be stronger. You might want to omit the use of built in methods like “setInterval” and just mention the methods you created specifically for your project, like “randomBurning” and “countDown”. And instead of linking your trello, slides and GitHub repo (which you don’t really need since people will see this from your GitHub repo) you could link your resources (where did you find the images, sounds and fonts for the game).
For better code readability, consider using more descriptive variable names instead of short ones, e.g., scoreHeading (instead of scoreH1), timeLeftHeading, squareElements, startButton. You want to also minimize the use of comments, remember, good code should speak for itself. By keeping things neat, organized, and using meaningful names, you can often nix the need for comments that just state the obvious. Your code is pretty clean and readable, so you could remove some comments.
I noticed you are only using game.js and index.js files on the project. So you can go ahead and remove the script.js file you have there, since it’s almost a duplicate of your game.js file, and you’re not using it.
Regarding the folder structure, consider moving the "sound" folder out of the "images" folder. This could tidy things up and make it better.
All in all these recommendations are just small tweaks to your already really good first project. As I told you before, it was nice that you chose something with a different logic than the race car game. You challenged yourself and succeeded. Keep up the good work! 🚀🔥🌳