maddev-engenuity / AdversaryEmulation

MAD ATT&CK Defender: ATT&CK Adversary Emulation Repository
Apache License 2.0
106 stars 22 forks source link

Fix how parameters are passed to Chocolatey Office 365 install #51

Closed activeshadow closed 2 years ago

activeshadow commented 2 years ago

In the current install-tools.ps1 script, the call to Chocolatey to install Office 365 applications doesn't seem to correctly parse the list of Office 365 applications to exclude. See the output below.

Installing the following packages:
office365business;/exclude:Access Groove Lync OneDrive OneNote Outlook Publisher Excel PowerPoint Teams
By installing, you accept licenses for the packages.
Progress: Downloading Office365Business 14729.20228... 100%

Office365Business v14729.20228 [Approved]
office365business package files install completed. Performing other installation steps.
No custom configuration specified. Generating one...
No Product ID specified, using default: O365BusinessRetail
No excluded apps specified, installing all
No Language ID specified, using default: MatchOS
No updates value specified, using default: TRUE
No updates value specified, using default: TRUE

The fix in this commit, based on official Chocolatey documentation, seems to address the issue given the output below.

Installing the following packages:
office365business
By installing, you accept licenses for the packages.
Progress: Downloading Office365Business 14729.20228... 100%

Office365Business v14729.20228 [Approved]
office365business package files install completed. Performing other installation steps.
No custom configuration specified. Generating one...
No Product ID specified, using default: O365BusinessRetail
The following apps will not be installed: Access Groove Lync OneDrive OneNote Outlook Publisher Excel PowerPoint Teams
No Language ID specified, using default: MatchOS
No updates value specified, using default: TRUE
No updates value specified, using default: TRUE