search

maddevsio / seo-analyzer

The library for analyze a HTML file to show all of the SEO defects
MIT License
78 stars 12 forks source link

Major bugfixes, add support for analyzing strings as variables and add Typescript support #21

Closed klandri closed 7 months ago

klandri commented 8 months ago

I don't know if this project is maintained at all anymore but I came across it and decided to use it. However the current state on NPM is buggy, with incorrect and outdated docs so I ended up fixing a lot of them. I also made Next support optional by making it a dynamic import since it seemed like overkill for this project. I also improved a lot of slightly awkward grammar in the strings and English docs. Since I don't speak Russian at I barely touched that readme.

We also needed to be able to analyze strings from memory so I added another input method for that. And similarly instead of just logging to console I added a method to return the JSON report to an external caller. Finally I added Typescript support throughout.

These changes are not entirely backward compatible since some functions are now async that were synchronous (but mostly broken) before.

If you're open to merging this that would be great but otherwise we can publish our own fork.

denisoed commented 7 months ago

I don't know if this project is maintained at all anymore but I came across it and decided to use it. However the current state on NPM is buggy, with incorrect and outdated docs so I ended up fixing a lot of them. I also made Next support optional by making it a dynamic import since it seemed like overkill for this project. I also improved a lot of slightly awkward grammar in the strings and English docs. Since I don't speak Russian at I barely touched that readme.

We also needed to be able to analyze strings from memory so I added another input method for that. And similarly instead of just logging to console I added a method to return the JSON report to an external caller. Finally I added Typescript support throughout.

These changes are not entirely backward compatible since some functions are now async that were synchronous (but mostly broken) before.

If you're open to merging this that would be great but otherwise we can publish our own fork.

@klandri Hi, thanks for the great and important update and for the grammatical error fixes. Yes, we don't support this package yet, but are open to any suggestions.

I like your changes, especially adding typescript to the project, thanks again.