search

maddouri / vscode-cmake-tools-helper

VSCode extension that enables cpptools to automatically know the information parsed by CMake Tools (e.g. include directories and defines)
https://marketplace.visualstudio.com/items?itemName=maddouri.cmake-tools-helper
BSD 3-Clause "New" or "Revised" License
16 stars 6 forks source link

Fixed crash on fileGroups == null #7

Closed gray-heron closed 6 years ago

gray-heron commented 7 years ago

Hello, when I tried to compile some ROS packages cmake-tools-helper crashed due to the fileGroups being undefined. If-ing out this case seems to fix all issues.

~Cheers

el-robo commented 6 years ago

This seems to fix the issues I was having with the extension as well. +1 for this

paulelsner commented 6 years ago

Would be great if that PR gets merged and you publish a new version of the extension. With the fix the extension works great!

bkinman commented 6 years ago

Somebody else should take over development of this extension, or it should be merged into the CMake Tools extensions, it's annoying that this PR has not been attended to.

maddouri commented 6 years ago

Hi,

Thanks for the PR.

I haven't had time to update the extension since... too long :) Hopefully, I'll try to free up some time to take care of the reported issues in the upcoming days.

Stay tuned!