Wrong return type on the release_date method

maddox / imdb-party

IMDB client using the IMDB API that their iPhone app uses

MIT License

117 stars 32 forks source link

Wrong return type on the release_date method #4

Closed oleander closed 13 years ago

oleander commented 13 years ago

The release_date method is sometimes returning a String instead of Date object. One example is the MASH movie (http://www.imdb.com/title/tt0066026/), see the test.

oleander commented 13 years ago

The bug appeared again, this time for a different movie. The first time the date was returned as a string with the value "2010-01" this time it returned "2010".

I've testet the lib on 4k movies, and it seams to work.

maddox commented 13 years ago

Closed, will not pull.

imdb_party uses shoulda + test unit, not rspec
some of these commits include things that have absolutely nothing to do with IMDB, like file system crawling.
you updated the README to be something totally different. Is this for real?

You seem to be creating an entirely different project. I'd suggest making your own project and simply using the imdb_party gem to do your imdb specific tasks.

oleander commented 13 years ago

Sorry, I'm new to this. :)

The pull request was only for the first 5 commits. I did't think that the rest would be added to the request.

Can you by any change just merge (if you want to) the first 5 commits, where I fixed the date bug? Those 5 commits where the only one that was ment to be merged.

Sorry, once again.

Do you want me to do another pull request? The bug still remains, right now this happens.

$ imdb.find_movie_by_id("tt0066026").release_date
=> "1970-03"