search

maddox / magic-cards

🎩 Queue music, play movies, or trigger events with RFID cards.
MIT License
578 stars 50 forks source link

Bump node to 9.11.2 #29

Closed balloob closed 5 years ago

balloob commented 5 years ago

I just did an install following the manual install instructions and I got this error:

error magic-cards-client@: The engine "node" is incompatible with this module. Expected version "9.11.1". Got "9.8.0"
error Found incompatible module

This was introduced in #14 when the client package.json got pinned to 9.11.1. The manual installation still has the user install Node 9.8.0. The repository linked in the manual installation contains installation scripts for 9.11.2 (the latest version), but not 9.11.1.

This PR bumps the node versions to 9.11.2 for Docker, client/package.json and the manual installation instructions.

maddox commented 5 years ago

Great! I ran into this last week.

It’s be great to get around this requirement of such a low version of node. It’s because of one of the libs I think.