Expose bitrate, encoder, and other params in config

maddox / wallop

📺 A transcoding server for your HDHomeRun Prime

167 stars 41 forks source link

Expose bitrate, encoder, and other params in config #62

Closed mjigmond closed 8 years ago

mjigmond commented 8 years ago

This is a suggestion for a future enhancement. I am using the graphics accelerated ffmpeg which uses a different video codec, h264_qsv instead of libx264. I'm also using wallop in conjunction with Roku-HDHomeRun and the quality seems to default to 3000k, but I would like it higher (ideal for hardwired connections). I also like to copy the audio as is instead of defaulting to 2 channel AAC. Thanks.

maddox commented 8 years ago

Bitrate is configurable already. It's probably being hard coded in Roku-HDHomeRun.

As for the video codec and audio codec stuff, that's fair. I'll look into it.

maddox commented 8 years ago

Check out #63. Pull down that branch and give it a try. Warning, I didn't even try it, as I don't really run Wallop anymore, so I don't have it set up, heh.

mjigmond commented 8 years ago

It works great, thanks! I'll see if @computmaxer is willing to modify the channel to expose quality settings. Otherwise I'll follow the example in your code changes to expose the bitrate in config.

maddox commented 8 years ago

I'll just merge this and you can use the regular checkout.