When attempting to add channel logo configurations for OTA channels which contain period characters, toml errors were received. Attempted to quote the key as recommended in the toml documentation without success. This PR allows the use of hyphens instead by adding a condition with a simple substitution.
Considered using sub! to avoid an additional condition, but decided not to do this to avoid potential regressions such as the channel name appearing with a dash instead of a period in the application and web interfaces.
Example error when period is used:
5.1 = "pbs.png"
wallop$ script/server
Failed to match sequence (ALL_SPACE (TABLE / TABLE_ARRAY / KEY_VALUE / COMMENT_LINE){0, } ALL_SPACE) at line 22 char 1.
`- Don't know what to do with "5.1 = \"pbs" at line 22 char 1.
/home/public/dev/wallop/lib/wallop.rb:54:in `expand_path': can't convert nil into String (TypeError)
from /home/public/dev/wallop/lib/wallop.rb:54:in `transcoding_path'
from /home/public/dev/wallop/lib/wallop.rb:59:in `setup'
from /home/public/dev/wallop/app/boot.rb:22:in `<top (required)>'
from app/app.rb:2:in `require'
from app/app.rb:2:in `<main>'
The error is not received when hyphens are used with the added condition present:
maddox
commented
7 years ago
When attempting to add channel logo configurations for OTA channels which contain period characters, toml errors were received. Attempted to quote the key as recommended in the toml documentation without success. This PR allows the use of hyphens instead by adding a condition with a simple substitution.
Considered using sub! to avoid an additional condition, but decided not to do this to avoid potential regressions such as the channel name appearing with a dash instead of a period in the application and web interfaces.
Example error when period is used:
The error is not received when hyphens are used with the added condition present: