search

madduccino / coding.space

The Coding Space Projects
12 stars 22 forks source link

CSS Animal Menagerie #122

Closed alexraby closed 5 years ago

alexraby commented 5 years ago

Hey there! Put this together for a more advanced CSS tutorial with a hint of animations, let me know what you think!

stevekrouse commented 5 years ago

[This is an automated integration to preview this pull request's changes to the website.]

https://raw.githack.com/alexraby/coding.space/9b5a82e61c46360d7ece157c7e288a3fe383167b/create.html

madduccino commented 5 years ago

Hey @alexraby! Thanks so much for submitting this project, it looks awesome! I have a few change requests before we merge:

  1. Make all the links (e.g. the w3c links) open in a new window. (That way students don't navigate away from the instructions.)
  2. Lowercase the properties you link to (e.g. "top" instead of "Top") so students know not to capitalize them.
  3. Add a link to the margin property on w3c in step 3
  4. Change the word 'canvas' to 'container' or 'div'. I worry that students will think they're being asked to make an HTML Canvas as is the case in other projects.
  5. Step 3 says to add a canvas using a background color and border and then step 11 says to remove the canvas at which point the border goes away but the background color remains. This confused me a little bit. Does it make more sense to say add a background color to the body and a border to the canvas (now div or container)?
  6. remove the .DS_Store files
  7. Add a thumbnail and link to the project on /web/index.html. I'll leave it up to you as to which level it should be in.
  8. Since you'll have it open, can you add <meta charset="UTF-8"> to the head section of /pure-css-images.html? This should be on all of our projects, but it became clear that it's missing when some of your characters appeared like this on my end:

screenshot 2019-02-26 at 12 50 05 pm