maddyblue / esc

A simple file embedder for Go
http://godoc.org/github.com/mjibson/esc
MIT License
637 stars 73 forks source link

new esc.Run signature requires more template #61

Open TomOnTime opened 5 years ago

TomOnTime commented 5 years ago

I recently upgraded to the newest version of this module and I noticed that esc.Run() now requires an io.Writer. That's awesome, however old code requires a lot of template (see https://github.com/StackExchange/dnscontrol/pull/515 for an example).

Would it make sense to have (for example) a nil writer result in the file being created automatically? This would help with migrating old code, and also would reduce the amount of template code needed.

Just a though!

maddyblue commented 5 years ago

Yes this should be the case.