search

maddyblue / goread

RSS reader in go on app engine; formerly goread.io
ISC License
2.38k stars 294 forks source link

favicons broken #305

Closed fredcy closed 9 years ago

fredcy commented 10 years ago

Since updating to commit 4d2df6085f909b3e65afb9375ff814d5202c9892 the feed icons on the left are mostly missing/broken. With Boing Boing, for example, goread is trying to get https://boingboing.net/favicon.ico but port 443 is not available on boingboing.net. If I manually get http://boingboing.net/favicon.ico that does work.

Seems like goread should use the scheme (http/https) of the feed when getting favicons rather than using "//" prefixed URLs that inherit its own scheme.

fredcy commented 10 years ago

This might be the same issue as #289. I notice that when I visit the admin page for a feed the img url value is correct and so is the displayed img image. But the feed list doesn't seem to use that. Instead it has a link directly to the feed site's favicon and always uses https scheme.

maddyblue commented 9 years ago

Should be fixed by #316

fredcy commented 9 years ago

I just rebuilt on 60e82ac0 and the favicons are working again. Thanks.