made2k / SunriseFasting

An iOS application for simple, easy, and free fasting.
https://apps.apple.com/us/app/sunrise-fasting/id1581300620
GNU General Public License v3.0
6 stars 1 forks source link

Thank you for the recent changes #35

Open aberja opened 2 years ago

aberja commented 2 years ago

Thank you for the recent changes. I have been using the app for a few days and the changes really enhance the app.

I have a few comments for your consideration:

  1. Cursor moving to the end - When I press return in the middle of a note to start a new paragraph, the cursor moves to the end of the note. The same thing happens when I hit the delete/backspace key on a blank line.

  2. Include fasting dates - Would it be possible to include the dates of the fast on the: a. screen with the note (perhaps just below the circle and above the times) and b. current fasting screen (perhaps just below Fast Started / Target end)?

  3. Mood - I really like the note and mood icons on the summary page. I was wondering if it would be a lot of work to allow one to have the option to show a number rather than an icon? The reason is that the icons are quite small and I find it a little difficult to see the difference between the icons. If room is an issue, I think it would be fine to remove the word "Mood:"

  4. Weight - Do you have plans on adding the ability to track weight?

  5. Note - I currently record notes during the day in another app and then copy them over when I close the fast. It would be nice to have the ability to add notes as a fast is open and eliminate the need for the other app.

  6. Summary updates - The following is a minor inconvience and only happens when one is making a change or adding a fast out of date order. The summary page does not update immediately after changes are made to a fast. For example, I changed the last fast start date to the day earlier. While the time in the circle on the note pages updated immediately, the information on the summary page does not update. To see the changes, I need to completely close the app and go back in. Also, if the change to the fast was for a date prior to an existing fast, the changed fast is not put in chronogical order.

made2k commented 2 years ago

Cursor moving to the end - When I press return in the middle of a note to start a new paragraph, the cursor moves to the end of the note. The same thing happens when I hit the delete/backspace key on a blank line.

Just saw this, seemed to happen after pressing delete on an empty line. It's real odd as to why it's doing that, but definitely something I'll check out.

Include fasting dates - Would it be possible to include the dates of the fast on the: a. screen with the note (perhaps just below the circle and above the times) and b. current fasting screen (perhaps just below Fast Started / Target end)?

Yeah I think adding the starting date as a navigation title would be good. That is similar to how some of Apple's apps work, you get something like"Sun, Sep 18" in the header when viewing details.

Mood - I really like the note and mood icons on the summary page. I was wondering if it would be a lot of work to allow one to have the option to show a number rather than an icon? The reason is that the icons are quite small and I find it a little difficult to see the difference between the icons. If room is an issue, I think it would be fine to remove the word "Mood:"

Not so much a spacing issue, but a issue of context. Seeing 1 vs 5 doesn't immediately lead to understanding what your mood was during that fast. An alternative might be words describing the mood. Something like "mood: Great" or "mood: bad". This would be an option that's able to toggle between emoji and text.

Weight - Do you have plans on adding the ability to track weight?

Maybe, but it'd add a dependency on HealthKit (which is actually a very nice API). But part of what I'm doing in keeping this app really simple, is that the maintenance for it is minimal (at least once everything is working properly). The biggest driver for me personally in not staying up to date with some of my personal apps is when they start to require a lot of work, since that takes time that can be hard for me to find. So this isn't something I'm looking to add now, but it is on my radar as I think some graphs may be neat to have in the app. iOS 16 also added a native graphing library that may ease some burden on that as well when it comes to development.

Note - I currently record notes during the day in another app and then copy them over when I close the fast. It would be nice to have the ability to add notes as a fast is open and eliminate the need for the other app.

Good info, current fasts are perfectly able to store a note, I just need to get an ability to add that in somewhere. I'll take a look at adding a button or something to add a note.

Summary updates - The following is a minor inconvience and only happens when one is making a change or adding a fast out of date order. The summary page does not update immediately after changes are made to a fast. For example, I changed the last fast start date to the day earlier. While the time in the circle on the note pages updated immediately, the information on the summary page does not update. To see the changes, I need to completely close the app and go back in. Also, if the change to the fast was for a date prior to an existing fast, the changed fast is not put in chronogical order.

This is a somewhat known issue. I'm not reloading the list of fasts after a change happens (so things can be edited to be non-chronological). I think this would be pretty minor though in terms of occurrence and impact, so it may not be worth updating since a fresh start of the app will put everything in chronologically. But I'll take a look to see if it'd make sense to reorder

aberja commented 2 years ago

Everything sounds great. With regards to weight and HealthKit, I completely understand. However, would you consider adding the ability to just record the number and not rely on HealthKit? Currently I put it in the note, but it would be nice to have it separate so I can track it.

made2k commented 2 years ago

In that case I'd actually recommend using HealthKit as it holds the record for you. Interacting with HealthKit directly can be a bit cumbersome since it's not easy to add data to areas, but a very simple shortcut is something I use. It lives in a widget on my home screen and I can add certain things to HK with it.

You can do that by:

  1. Open the Shortcut app (install if need be)
  2. Create new shortcut
  3. Add action
  4. Search for Health and select "Log Health Sample"
  5. In the type field choose "Weight"
  6. Value choose "Ask Each Time"

Then give it a name and done! That makes it real easy to add weight to HealthKit.

Regardless, I have some changes coming soon that addresses 1 and 2. I'll see soon about getting something in for 3 too.

I had a version where notes could be added on the active fast screen, but what I'm guessing is an issue with SwiftUI lead it to a very bad UX experience and it wasn't something I wanted to go out with. Basically when the keyboard appeared it shifted everything up and distorted the underlying screen. Apple implemented an API to address that, but when using it, it had no affect. So the interface kept getting distorted in a really bad way. I'll hold off on that for now.