madeITBelgium / Wappalyzer

PHP Library that uncovers the technologies used on websites.
GNU General Public License v3.0
12 stars 7 forks source link

Current apps.json file load is backwards and over complicated #1

Closed Austinb closed 5 years ago

Austinb commented 5 years ago

Current code fails when using Laravel facade with a cURL error because it is trying to make guzzle load the local file ./vendor/madeitbelgium/wappalyzer/src/apps.json by default. Use PHP's filter_var and validate for URL that way. Otherwise assume the file is local. Also file_get_contents() can read remote locations but I suppose using guzzle is preferable.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 13


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Wappalyzer.php 0 3 0.0%
<!-- Total: 0 3 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/Wappalyzer.php 165 0.0%
<!-- Total: 165 -->
Totals Coverage Status
Change from base Build 11: -79.3%
Covered Lines: 0
Relevant Lines: 416

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 14


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Wappalyzer.php 0 3 0.0%
<!-- Total: 0 3 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/Wappalyzer.php 165 0.0%
<!-- Total: 165 -->
Totals Coverage Status
Change from base Build 11: -79.3%
Covered Lines: 0
Relevant Lines: 624

💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 13


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Wappalyzer.php 0 3 0.0%
<!-- Total: 0 3 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/Wappalyzer.php 165 0.0%
<!-- Total: 165 -->
Totals Coverage Status
Change from base Build 11: -79.3%
Covered Lines: 0
Relevant Lines: 416

💛 - Coveralls
madeITBelgium commented 5 years ago

@Austinb thank you. I released a new version (1.1.0) with updated wappalyzer data.