search

madebymany / sir-trevor-rails

Rails gem for Sir Trevor integration.
MIT License
149 stars 50 forks source link

Update to latest version of sir-trevor-js master branch and fix bindFormSubmit #19

Open Marthyn opened 10 years ago

Marthyn commented 10 years ago

Add new javascript and css

Also made a fix SirTrevor.bindFormSubmit 2e4125faa5f9798368b61feb1c0f549204251cab The formbound variable is set to the SirTrevor object. This means when you have multiple instances the formBound attribute will be set as true on the first time and won't bind onFormSubmit to the other forms. This broke our application and therefor we made this fix. Maybe this is not the best solution, but it works for us. A formBound on the Editor instance would maybe work?

Marthyn commented 10 years ago

I just saw problems when adding new types of content, i will make views in ruby for that and update this pull request.

Marthyn commented 10 years ago

Finished new blocks, can be merged.

adtaylor commented 10 years ago

Is there any reason why this pull-request is dead? It would be great to have the latest version of Sir-Trevor in here.

Marthyn commented 10 years ago

I haven't worked on it because we don't use it anymore. Also i never got a reaction to this PR unfortunately. I did really like the code and wouldn't mind keeping this up if there's a need for that.