madebymany / sir-trevor-rails

Rails gem for Sir Trevor integration.
MIT License
149 stars 50 forks source link

Redesign gem #29

Closed ninjabiscuit closed 9 years ago

ninjabiscuit commented 10 years ago

Updated all the things (mostly, implemented everything we did on dotcom):

Take a look at the updated readme file for more info

There are no tests for this yet (:trollface:) but people are having problems with the old gem and this addresses most (all) of those issues.

...so... maybe we should just release it? Unless anyone has time to write the tests soon?

Fudoshiki commented 10 years ago

$ rails g sir_trevor_rails:views DL is deprecated, please use Fiddle c:/Ruby212-x64/lib/ruby/gems/2.1.0/bundler/gems/sir-trevor-rails-e1c7de50443a/li b/sir_trevor_rails/view_resolver.rb:2:in `module:SirTrevorRails': uninitialize d constant ActionView::FileSystemResolver (NameError)

hayesr commented 10 years ago

If anyone is interested, I recently implemented this branch in a toy CMS built on Rails 4.1. You can see it here: https://github.com/hayesr/clonepress/tree/trevor

I think I had to deviate a few times from the Readme instructions. If I get a chance I will submit a PR.

hayesr commented 10 years ago

I forgot to mention that this small change appears to be needed for Rails 4.1 compat.