Remove bin/rake - Githubissues

madebymany / sir-trevor-rails

Rails gem for Sir Trevor integration.

MIT License

149 stars 50 forks source link

Closed cbeer closed 9 years ago

cbeer commented 9 years ago

I believe this file was unintentionally committed.

lukaszsagol commented 9 years ago

Why do you think that we shouldn't commit binstubs?

I know some consider that user environment config, but we all use bundler anyway.

cbeer commented 9 years ago

If you commit binstubs and export executables (as is the case here: https://github.com/madebymany/sir-trevor-rails/blob/master/sir_trevor_rails.gemspec#L23), you're REPLACING the rake (gem) rake (executable) with your binstub (which breaks things badly.)

lukaszsagol commented 9 years ago

Right, right, right.

That makes sense, I missed that.

Thanks for the PR :+1: