search

madebymany / sir-trevor-rails

Rails gem for Sir Trevor integration.
MIT License
149 stars 50 forks source link

Remove dependence on request object. #4

Closed danbee closed 11 years ago

danbee commented 11 years ago

I've removed the dependence on the request object by using protocol agnostic URL's in the views. This also makes it easier to test.

danbee commented 11 years ago

It would be quite nice if there was some sort of integration with dragonfly or paperclip for images. You'd still need to specify the image format somehow though.

It might also be worth looking at writing some specs, as this would make refactoring less brittle. I might look at this soon if I find time.