search

madebymany / sir-trevor-rails

Rails gem for Sir Trevor integration.
MIT License
149 stars 50 forks source link

Update SirTrevorRails::ViewResolver to be compatible with Rails 4.2.5.1 #49

Closed cbeer closed 8 years ago

cbeer commented 8 years ago

Rails 4.2.5.1 added a fifth argument to #find_templates. Since we don't particularly care what the arguments are, we can just pass them through.

dwb commented 8 years ago

Sorry, didn't see this one and did it myself :no_mouth: Thanks though!

cbeer commented 8 years ago

Thanks, not a problem. Could we get a new release of the gem with this change?

dwb commented 8 years ago

We decided to release 0.5.0. I’ve just pushed it, so should be available any minute.

On 27 Jan 2016, at 23:46, Chris Beer notifications@github.com wrote:

Thanks, not a problem. Could we get a new release of the gem with this change?

— Reply to this email directly or view it on GitHub https://github.com/madebymany/sir-trevor-rails/pull/49#issuecomment-175913927.

Made by Many Limited is registered in England and Wales (No.06346338). Registered office: Diespeker Wharf, 38 Graham Street, London, N1 8JX, UK

Made by Many Inc is registered in the State of New York (No.4427021). 65 Greene Street, 4th Floor, New York, NY 10012, USA

cbeer commented 8 years ago

Thanks!