search

madebysource / lesshat

Smart LESS CSS mixins library.
lesshat.com
MIT License
2.19k stars 259 forks source link

v3.0.3 breaking changes #170

Closed TSteele27 closed 8 years ago

TSteele27 commented 8 years ago

With the latest release of lesshat you removed the build folder from the npm package. This breaks integrations that were expecting the prebuilt version of lesshat to exist. I would expect a change like this to come as a major version change not a patch version change.

mboudreau commented 8 years ago

Crap, my bad. That definitely shouldn't be the case. Deployment teething issues. I'll unpublish this version and create a new one.

On Fri, Jun 10, 2016 at 2:19 AM TSteele27 notifications@github.com wrote:

With the latest release of lesshat you removed the build folder from the npm package. This breaks integrations that were expecting the prebuilt version of lesshat to exist. I would expect a change like this to come as a major version change not a patch version change.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/madebysource/lesshat/issues/170, or mute the thread https://github.com/notifications/unsubscribe/AAjA5IH9GS0ZB6JPBZKkYnz_2eQTHpb1ks5qKDz_gaJpZM4IyJz0 .

mboudreau commented 8 years ago

Yeah, after some thought, since the deployment hasn't gone out in so long, there is going to be some risk involved. I'll update the version number to 4.0.0 so it shouldn't affect any builds and people can proceed at their own risk.

rmunson commented 8 years ago

@mboudreau So this issues is closed now, as 4.x takes over this change... but I'm curious, what is the end-game of removing the build directory?
Should everyone using lesshat now have a an additional build step for dev?

Or is the plan to include the build folder in future tags (which seems to make the most sense)?

If you are cutting a release, shouldn't it contain built files?

mboudreau commented 8 years ago

Generated files should never be part of the source. The whole point of a release is to generate these files and deploy them into an artifact. This is what npm is for.

If you're using bower, I strongly recommend to move away from it since it breeds bad practices. If you really have to use bower, you can always point it to the npm zip file for that particular version.

Hope that answers your question.

M

On Wed, Jun 29, 2016, 5:31 AM Russell Munson notifications@github.com wrote:

@mboudreau https://github.com/mboudreau So this issues is closed now, as 4.x takes over this change... but I'm curious, what is the end-game of removing the build directory?

Should everyone using lesshat now have a an additional build step for dev?

Or is the plan to include the build folder in future tags (which seems to make the most sense)?

If you are cutting a release, shouldn't it contain built files?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/madebysource/lesshat/issues/170#issuecomment-229156896, or mute the thread https://github.com/notifications/unsubscribe/AAjA5KW8F7TGiGku4fCNFFTqoLLUZMQOks5qQXaLgaJpZM4IyJz0 .

rmunson commented 8 years ago

While I generally agree with you re: generated files and source, lesshat is a bit of a different animal. The output of the project is source code (less files), not a stand-alone deployable.

Looks like you've dropped support for bower altogether for 4.x+. It would be nice if there was a statement to that affect in the Readme or on lesshat.com, especially since the bower registry will continue to point users at newly tagged versions.

mboudreau commented 8 years ago

Not a bad idea. I'll get to it tonight.

On Thu, Jun 30, 2016 at 2:39 AM Russell Munson notifications@github.com wrote:

While I generally agree with you re: generated files and source, lesshat is a bit of a different animal. The output of the project is source code (less files), not a stand-alone deployable.

Looks like you've dropped support for bower altogether for 4.x+. It would be nice if there was a statement to that affect in the Readme or on lesshat.com, especially since the bower registry will continue to point users at newly tagged versions.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/madebysource/lesshat/issues/170#issuecomment-229414615, or mute the thread https://github.com/notifications/unsubscribe/AAjA5Gjx6o5-M7sRm6vTVaQNtW72RK6gks5qQp_HgaJpZM4IyJz0 .

mboudreau commented 8 years ago

@rmunson sorry for taking a while to get to this. I've added instructions about how to use bower in the new method.

Cheers.