madebysource / lesshat

Smart LESS CSS mixins library.
lesshat.com
MIT License
2.19k stars 258 forks source link

Keyframes stripping out semicolons on main @keyframe declaration #83

Closed EvHaus closed 10 years ago

EvHaus commented 10 years ago

Using LESSHat 2.0.14, the following LESS code:

.keyframes(~'test, 0%{ display: none; opacity: 0 } 1%{display: block; opacity: 0 } 100%{ display: block; opacity: 1 }');

Will generate the following CSS code:

@-webkit-keyframes test{0%{display:none;opacity:0}1%{display:block;opacity:0}100%{display:block;opacity:1}}

@-moz-keyframes test{0%{display:none;opacity:0}1%{display:block;opacity:0}100%{display:block;opacity:1}}

@-o-keyframes test{0%{display:none;opacity:0}1%{display:block;opacity:0}100%{display:block;opacity:1}}

@keyframes test{0%{display:none opacity:0}1%{display:block opacity:0}100%{display:block opacity:1}}

Note that -webkit-, -moz- and -o- all correctly have semicolons between display and opacity definitions, but the HTML5 @keyframes declaration is missing semicolons -- which results in a broken style.

petrbrzek commented 10 years ago

I tried it to replicate but the result is fine. Could you give me more information? Like what are you using to compile LESS, your LESS version lessc -v.

Thanks

EvHaus commented 10 years ago

I'm pretty out-dated: lessc 1.3.3. Maybe that's the issue.

petrbrzek commented 10 years ago

Try to update and get to know if it's fine. :)

EvHaus commented 10 years ago

Confirmed. Issue is gone in LESS 1.6.4