madebysource / lesshat

Smart LESS CSS mixins library.
lesshat.com
MIT License
2.19k stars 258 forks source link

Flexbox legacy implementation errors #89

Closed monovertex closed 10 years ago

monovertex commented 10 years ago

I encountered this while using the .justify-content mixin, but it applies to the other flexbox mixins with legacy syntax support.

The result for .justify-content is (in practice and in the docs):

// Result
div {
 -webkit-box-pack: flex-start;
 -moz-box-pack: start;
 -webkit-justify-content: start;
 -ms-flex-pack: flex-start;
 justify-content: flex-start;
}

However, the -webkit-box-pack also takes start as value, not flex-start (same as the -moz- prefix).

The current implementation causes Safari 5.1.7 on Windows (which only has legacy flexbox support) to ignore the -webkit-box-pack property, but with start it works as designed.

I think this applies (but I did not test it) to the other box- flexbox properties, like align-items (box-align).

EDIT: On a second look, I think the values for -webkit-box-pack and -webkit-justify-content are just mixed up.

petrbrzek commented 10 years ago

I'll look at it as soon as possible. Thanks for notifying me.

yoohahn commented 10 years ago

Looks to be the same issue that i've encounterd for IE10 and Safari for iPad; https://github.com/csshat/lesshat/issues/96

petrbrzek commented 10 years ago

Fixed in 3.0.