https not supported - Githubissues

madecoste / music-beta-controller

Automatically exported from code.google.com/p/music-beta-controller

0 stars 0 forks source link

https not supported #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. visit https://music.google.com/music/listen
2. click extension's button

What is the expected output? What do you see instead?
Should play or pause music in the open google music tab

What version of the product are you using? On what operating system?
latest, mac

Please provide any additional information below.
the line:
if (windows[window].tabs[i].url.indexOf('http://music.google.com/music/listen') 
== 0)
needs to be changed to support https

Original issue reported on code.google.com by jonat...@crem.in on 30 May 2011 at 8:58

GoogleCodeExporter commented 9 years ago

version is 1.0.1

Original comment by jonat...@crem.in on 30 May 2011 at 8:59

GoogleCodeExporter commented 9 years ago

Good catch... I'll change the code for a regex instead...

Thanks!

Original comment by mad@chromium.org on 30 May 2011 at 2:44

Changed state: Started

GoogleCodeExporter commented 9 years ago

Original comment by mad@chromium.org on 30 May 2011 at 3:10

Added labels: Priority-High, OpSys-All, Component-Logic, Usability
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

Revision: 
http://code.google.com/p/music-beta-controller/source/detail?r=b3a39a88ee0eb5f3e
22875cac0e4b89fbfed1adf

Now available in version 1.0.2 of both the Play/Pause and Skip extensions.

Original comment by mad@chromium.org on 30 May 2011 at 5:22

Changed state: Fixed