Rewrite the bot API

[GoogleCodeExporter]

The bot API needs some love. It's going to be completely rewritten.

Original issue reported on code.google.com by maruel@chromium.org on 16 Jun 2014 at 6:01

• Blocking: #116, #115, #124

[GoogleCodeExporter]

Original comment by maruel@chromium.org on 16 Jun 2014 at 6:01

• Now blocking: #116

[GoogleCodeExporter]

Original comment by maruel@chromium.org on 16 Jun 2014 at 6:01

• Now blocking: #115

[GoogleCodeExporter]

Issue 49 has been merged into this issue.

Original comment by maruel@chromium.org on 16 Jun 2014 at 6:53

[GoogleCodeExporter]

Original comment by maruel@chromium.org on 17 Jun 2014 at 3:33

• Now blocking: #124

[GoogleCodeExporter]

We're seeing this kind of error on chromium-swarm. It's quite frequent so it 
needs to be fixed ASAP. This will be fixed by the new bot code, which will 
force utf-8 encoded strings. As of new, there's 5 CLs pending review to enable 
the new bot code to use the new bot API.

UnicodeDecodeError@decode
Handler: main.app
Modules: default
Versions: 914-cdc4856
POST 
chromium-swarm.appspot.com/result2?r=147d656519b9f01&id=swarm141-c4&UrlOpenAttem
pt=29 (HTTP 500)
'utf8' codec can't decode byte 0xd8 in position 141590: invalid continuation 
byte
Traceback (most recent call last):
  File "third_party/webapp2-2.5.2/webapp2.py", line 1535, in __call__
    rv = self.handle_exception(request, response, e)
  File "third_party/webapp2-2.5.2/webapp2.py", line 1529, in __call__
    rv = self.router.dispatch(request, response)
  File "third_party/webapp2-2.5.2/webapp2.py", line 1278, in default_dispatcher
    return route.handler_adapter(request, response)
  File "third_party/webapp2-2.5.2/webapp2.py", line 1102, in __call__
    return handler.dispatch()
  File "components/auth/handler.py", line 127, in dispatch
    return super(AuthenticatingHandler, self).dispatch()
  File "third_party/webapp2-2.5.2/webapp2.py", line 572, in dispatch
    return self.handle_exception(e, self.app.debug)
  File "third_party/webapp2-2.5.2/webapp2.py", line 570, in dispatch
    return method(*args, **kwargs)
  File "components/auth/api.py", line 596, in wrapper
    return func(*args, **kwargs)
  File "handlers_frontend.py", line 1471, in post
    packed = self.request.get('r', '')
  File "third_party/webapp2-2.5.2/webapp2.py", line 175, in get
    param_value = self.get_all(argument_name)
  File "third_party/webapp2-2.5.2/webapp2.py", line 212, in get_all
    param_value = self.params.getall(argument_name)
  File "third_party/webob-1.2.3/webob/request.py", line 832, in params
    params = NestedMultiDict(self.GET, self.POST)
  File "third_party/webob-1.2.3/webob/request.py", line 783, in POST
    vars = MultiDict.from_fieldstorage(fs)
  File "third_party/webob-1.2.3/webob/multidict.py", line 92, in from_fieldstorage
    obj.add(field.name, decode(value))
  File "third_party/webob-1.2.3/webob/multidict.py", line 78, in <lambda>
    decode = lambda b: b.decode(charset)
  File "/python2.7/encodings/utf_8.py", line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xd8 in position 141590: 
invalid continuation byte

Original comment by maruel@chromium.org on 14 Aug 2014 at 10:50

[GoogleCodeExporter]

Original comment by maruel@chromium.org on 18 Sep 2014 at 6:25

• Changed state: Fixed