Remove 'isolate_dependency_touched' and merge 'isolate_dependency_tracked' and 'isolate_dependency_untracked' into one

[GoogleCodeExporter]

Per https://codereview.chromium.org/468773003/#msg10, we should simplify our 
isolate files by only having one list for dependencies. There's no need to have 
separate lists.

Original issue reported on code.google.com by jam@chromium.org on 25 Aug 2014 at 11:22

[GoogleCodeExporter]

We may want to take a stab at it before rolling out many .isolate in chromium. 
On the other hand the conversion should be fairly trivial to do so it's not a 
big deal either way.

The current format was to be GYP compatible but in practice it's not useful, so 
the format should be greatly simplified.

Original comment by maruel@chromium.org on 4 Sep 2014 at 8:11

• Added labels: Type-Feature, Usability
• Removed labels: Type-Bug

[GoogleCodeExporter]

Personally I would prefer if this data gets merged into the gyp and then the gn 
files.

First, we shouldn't list binaries. Right now that's a lot of the contents of 
the isolate file. The isolate system should extract this information itself so 
developers don't have to duplicate the dependencies of each test binary in gyp 
targets and in isolate lists.

Once we do that, we will have a small number of test directories. We should 
list them in the gyp/gn files, which is what google3 does afaik.

Original comment by jam@chromium.org on 4 Sep 2014 at 8:23

[GoogleCodeExporter]

+1 to having the description of our tests' data dependencies in our 
dependency-description files :)

Ideally we wouldn't have to do it for gyp+gn (hopefully we could only do it for 
gn), but I don't know if that's realistic. Maybe there's a quick way to add it 
to gyp without too much fuss?

Original comment by iannucci@chromium.org on 4 Sep 2014 at 8:57

[GoogleCodeExporter]

I'd prefer to skip updating GYP file and only focus on a GN compatible way. But 
since the roll out will take a long time, continuing to use .isolate buys us 
the fact that we do not have to care about the migration.

So yes the .isolate would disappear long term, but likely not until the last 
gyp file also disappear.

Original comment by maruel@chromium.org on 4 Sep 2014 at 9:01

[GoogleCodeExporter]

There are two issues here:
-not duplicating the binary dependencies in the isolate files: I believe 
Marc-Antoine already has a way of isolate using this from the ninja files? This 
shouldn't be blocked on the gyp/gn migration since it's orthogonal.

-listing the test data in the build files. right now, gn already has a way to 
share data from gyp files. so if we listed the dictionary in the gyp file, gn 
can reference it in the meantime.

Original comment by jam@chromium.org on 4 Sep 2014 at 9:05

[GoogleCodeExporter]

src/tools/isolate_driver.py is the tool that process .ninja files and deduce 
the runtime dependencies. It's a stop gap until GN support to extract this 
information is written. It's not practically possible to do it in GYP. On the 
other hand, it's cheeze and I'd rather remove this the sooner the better.

If it's possible to share the static file data already, I'll all open to this. 
Long term, I'd rather get rid of .isolate files completely. This specific issue 
is about making them more bearable in the meantime.

Original comment by maruel@chromium.org on 4 Sep 2014 at 9:21

[GoogleCodeExporter]

I agree right now combining the two lists into one would be an improvement :)

My comments I guess really apply if we want to add isolate files for all the 
targets. Then the overhead of listing the binary dependencies is worse if we do 
50 targets vs ~6 or 7 now.

Original comment by jam@chromium.org on 5 Sep 2014 at 2:57

[GoogleCodeExporter]

Raising priority, grabbing.

Original comment by maruel@chromium.org on 30 Sep 2014 at 5:34

• Changed state: Started
• Added labels: Priority-0
• Removed labels: Priority-3

[GoogleCodeExporter]

Original comment by maruel@chromium.org on 30 Sep 2014 at 5:50

[GoogleCodeExporter]

Almost done, only need to remove support for the old format.

Original comment by maruel@chromium.org on 4 Oct 2014 at 12:22

[GoogleCodeExporter]

Original comment by maruel@chromium.org on 27 Nov 2014 at 2:55

• Changed state: Fixed