search

madecoste / swarming

Automatically exported from code.google.com/p/swarming
Apache License 2.0
0 stars 1 forks source link

Add visibility to the task running of the swarming bot id #185

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Similar in spirit to run_isolated.py's ISOLATED_OUTDIR, we could add 
SWARMING_BOT_ID.

The main issue is that it's task_runner.py that would need to process this, as 
run_isolated has no visibility about swarming. But task_runner.py has itself 
both low visibility on the task being run and on the bot. For example, it 
doesn't know about arguments inside the .isolated file.

On the other hand, bot_main.py already sets SWARMING_HEADLESS=1. So a natural 
and simpler option is to set the environment variable SWARMING_BOT_ID inside 
bot_main.py and be done with it. This is very one-off but gets the job done.

Original issue reported on code.google.com by maruel@chromium.org on 2 Dec 2014 at 2:35

GoogleCodeExporter commented 9 years ago

Original comment by maruel@chromium.org on 3 Dec 2014 at 6:21