search

madecoste / swarming

Automatically exported from code.google.com/p/swarming
Apache License 2.0
0 stars 1 forks source link

Remove Catch For All Exceptions #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In test_manager.py, in the function _EmailTestResults a call to mail.send_mail 
is in a try block where we catch all exceptions. Even though the exceptions are 
logged this can result in a valid (but not directly related to send_mail) 
exception getting caught.

The catch should be updated so that it only catches the exceptions that we 
actually expect from mail.send_mail

(Is it still a problem?)

Original issue reported on code.google.com by maruel@chromium.org on 7 Jan 2014 at 8:36

GoogleCodeExporter commented 9 years ago 
It is still partial a problem (we don't ever use that code with chromium so we 
won't encounter any issues with it)

Original comment by csharp@chromium.org on 7 Jan 2014 at 8:50

GoogleCodeExporter commented 9 years ago 
Fixed in 983f3c69419510d424884f016e740e920315148d, the code was removed.

Original comment by maruel@chromium.org on 12 Jun 2014 at 9:00