search

madecoste / swarming

Automatically exported from code.google.com/p/swarming
Apache License 2.0
0 stars 1 forks source link

On Windows, differing capitalization causes file to be silently excluded from isolate #71

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Please see https://codereview.chromium.org/130983008 .

I got the capitalization of the file D3DCompiler_46.dll wrong. In out/Release, 
it's actually d3dcompiler46_dll. The built isolates simply didn't contain this 
file. This should have been reported as an error instead of silently failing.

Original issue reported on code.google.com by kbr@chromium.org on 25 Jan 2014 at 1:21

GoogleCodeExporter commented 9 years ago 
The isolate.py tool enforces path case to enforce determinism. This ensures the 
.isolated sha-1 is reproducible.

The problem is that --ignore_broken_items is currently used in 
build/isolate.gypi. Sadly this flag can't be removed at the moment due to 
component builds and other unsupported builds. This flag makes it possible to 
detect removal or incorrect casing.

Original comment by maruel@chromium.org on 12 Feb 2014 at 1:35

GoogleCodeExporter commented 9 years ago 
It was fixed in 582e224ef1d90c1a75d60d0668e04a53efb88adb, I disabled path 
enforcement but that fixed inconsistent path issue.

Original comment by maruel@chromium.org on 6 Aug 2014 at 3:17