search

maded2 / plotng

PlotNG - plotting utility for Chia.Net
Apache License 2.0
128 stars 24 forks source link

suggestion: allow explicit spare and temp space check #53

Open markkundinger opened 3 years ago

markkundinger commented 3 years ago

hi! First of all I think this tool is super cool and has made my plotting life a lot better than just using the stupid broken Chia GUI.

right now we have DiskSpaceCheck. Which checks space in the destination directory for approx 105GB free...

1) as a possible bug report, when I run plotng on a windows system and my destination drive is a mapped SMB share, I always get an error that the drive (0b free)is full despite having space.

2) I think it would be good if we could specify our own disk space requirement. Maybe we're plotting bigger work units, or maybe we just need to reserve space for other things.

3) I also think we should have an option to check the temp drive for space. Because: a) the temp drive can also run out of space which is bad b) if the temp drive and destination are the same, then we'd need more space c) to accomodate for other things going on in that drive. like other chia plotters or regular productivity usage.

maded2 commented 3 years ago

not sure about No.1 as I used a library which gives the free disk space, not sure it works on SMB share. I will add support other plot size in the future.

Plopsi commented 3 years ago

Hey @maded2 really nice tool.

Regarding @markkundinger requests.

  1. On Windows you need to assign a driveletter to the share, then you get free space reported, otherwise it's always 0.

and for 3.a I experimented on a fork and implemented such a check. Rudimentary, hardcoded and messy as I'm not used to GOLang but so far it works very nicely for me - only tested on windows (https://github.com/Plopsi/plotng/blob/feature/tmp-space/internal/server.go#L135-L216) maybe @maded2 wants to implement it cleaner and configureable ;)