search

madeindjs / nestjs-graphile-worker

A Nest.js wrapper for Graphile Worker
https://www.npmjs.com/package/nestjs-graphile-worker
MIT License
35 stars 14 forks source link

fix: await events to be registered #11

Closed MarcK98 closed 1 year ago

MarcK98 commented 1 year ago

This PR attempts to fix issue #3

After some debugging, I found out that this code block

const events = this.listenerExplorerService.listeners.map(
      ({ event }) => event,
);

is being called with empty events, meaning the listenerExplorerService hasn't been fully initialized yet. This fix awaits the listenerExplorerService to be fully initialized before registering the events.

CharbelFarah commented 1 year ago

finally! thanks for this

AnthonyAbouChacra96 commented 1 year ago

At lassstt!! Nice job, keep on the good work 💪🏻💪🏻 LGTM !!!

madeindjs commented 1 year ago

Great! I'll publish the new version on NPM soon. I keep you posted. Thanks

madeindjs commented 1 year ago

Published as v0.3.1

MarcK98 commented 1 year ago

Much appreciated!

harout7 commented 1 year ago

Looking good!!! This is great.