search

madeintandem / jsonb_accessor

Adds typed jsonb backed fields to your ActiveRecord models.
MIT License
1.11k stars 93 forks source link

gem release 1.3.8-java is invalid #164

Closed ashkulz closed 1 year ago

ashkulz commented 1 year ago

If you compare the dependencies of 1.3.7-java vs 1.3.8-java they're different in pg vs activerecord-jdbcpostgresql-adapter.

I guess @haffla forgot to build the -java gem on JRuby, but I'm not sure what really happened :man_shrugging:

haffla commented 1 year ago

Hey @ashkulz sorry. I actually did build the gem for Java and pushed. I did gem build --platform java. But that's not enough apparently. Of course I need to do that using jruby. I had forgotten exactly how to do it.

Please check https://rubygems.org/gems/jsonb_accessor/versions/1.3.10-java. Let me know if that works.

I've create a script for building for both platforms now.

ashkulz commented 1 year ago

Thanks, looks good to me @haffla! As ever, thanks for the fast turnaround :clap:

ashkulz commented 1 year ago

@haffla can you release jsonb_accessor 1.3.10 (regular version)? Dependabot is confused because only one is released and not the other:

Screenshot 2023-05-31 at 10-18-21 Bump jsonb_accessor from 1 3 8 to 1 3 10 by dependabot · Pull Request #7095 · teamsimplepay_simplepay

haffla commented 1 year ago

Aiaiaiai, fixed now :)

ashkulz commented 1 year ago

Thanks, confirm that it works :tada: