Support PostCSS v6 - Githubissues

madeleineostoja / rucksack

A little bag of CSS superpowers, built on PostCSS

https://www.rucksackcss.org

Other

1.85k stars 58 forks source link

Support PostCSS v6 #55

Closed perrin4869 closed 7 years ago

perrin4869 commented 7 years ago

Is there any plan to upgrade the dependencies? Thanks!

madeleineostoja commented 7 years ago

Looks like v6 was a pretty small changeset, but moving all the plugins bundled with Rucksack to v6 will probably still be a big job - would happily accept PRs!

perrin4869 commented 7 years ago

I see! Will definitely try to help in the coming days then :D

perrin4869 commented 7 years ago

[x] postcss-alias (PR: https://github.com/seaneking/postcss-alias/pull/5)
[x] postcss-clearfix (PR: https://github.com/seaneking/postcss-clearfix/pull/21)
[x] postcss-color-rgba-fallback (Fixed in v3)
[x] postcss-easings
[x] postcss-fontpath (PR: https://github.com/seaneking/postcss-fontpath/pull/9, https://github.com/seaneking/postcss-fontpath/pull/10)
[x] postcss-hexrgba (PR: https://github.com/seaneking/postcss-hexrgba/pull/8)
[x] postcss-input-style (PR: https://github.com/seaneking/postcss-input-style/pull/3)
[ ] postcss-opacity (PR: https://github.com/iamvdo/postcss-opacity/pull/13)
[x] postcss-position (PR: https://github.com/seaneking/postcss-position/pull/9)
[x] postcss-pseudoelements (Fixed in v5)
[x] postcss-quantity-queries
[x] postcss-reporter
[x] postcss-responsive-type (PR: https://github.com/seaneking/postcss-responsive-type/pull/28)
[x] postcss-vmin

perrin4869 commented 7 years ago

I'm taking a vacation next week so I won't be able to help out anymore until I'm back =/

madeleineostoja commented 7 years ago

This looks great! Thanks for the help :-)

I've merged postcss-responsive-type and pushed a major (released as v1.0, interface has been stable for over a year), others need Node versions bumped in Travis config to pass tests.

Once everything is updated I'll bump all deps for rucksack and release a 0.10.0 (few breaking issues to sort before releasing 1.0 of Rucksack)

perrin4869 commented 7 years ago

Fixed the tests on postcss-alias and postcss-clearfix, I'll try to send the rest of the PRs this week!

madeleineostoja commented 7 years ago

Awesome thanks!

perrin4869 commented 7 years ago

Nice, thanks for the merges, we're getting close :D

perrin4869 commented 7 years ago

PRs all done now!!

madeleineostoja commented 7 years ago

Great! Sorry missed this before, I'll try have a look over all of them later today

madeleineostoja commented 7 years ago

Cool, all mine merged in and bumped to v1.0 - just waiting on https://github.com/iamvdo/postcss-opacity/pull/13, then can bump deps here (and in laggard).

perrin4869 commented 7 years ago

That's awesome, thanks!!!

perrin4869 commented 7 years ago

https://github.com/iamvdo/postcss-opacity/pull/13 was merged an released as postcss-opacity@5 :D

madeleineostoja commented 7 years ago

Okay great! Away for the weekend but will bump deps on rucksack when I'm back. Would like to release this as a 1.0 (since postcss 6 is a breaking change anyway), and to do that would require:

Bumping all deps
Removing postcss-alias
Add changelog
Updating docs and website for new plugin features (responsive type, fontpath, etc)
Ideally also adding config options to plugins rather than just true/false Boolean. This could potentially be a non-breaking change though if they could take a Boolean or an object

Not sure when I'll get a chance to do all that, but hopefully soon.

madeleineostoja commented 7 years ago

Done and released as 1.0, will leave other breaking changes for 2.0

perrin4869 commented 7 years ago

Awesome :D