Open oxinabox opened 3 years ago
running the tests was erroring with:
ERROR: LoadError: LoadError: LoadError: type CategoricalValue has no field value Stacktrace: [1] getproperty(x::CategoricalValue{String, UInt8}, f::Symbol) @ Base ./Base.jl:33 [2] isnan(x::CategoricalValue{String, UInt8}) @ LowRankModels ~/JuliaEnvs/LowRankModels.jl/src/fit_dataframe.jl:275 [3] (::LowRankModels.var"#147#148"{DataFrame, Int64})(::Tuple{Int64, CategoricalValue{String, UInt8}}) @ LowRankModels ./none:0 [4] iterate @ ./generator.jl:47 [inlined] [5] collect(itr::Base.Generator{Base.Iterators.Enumerate{CategoricalVector{String, UInt8, String, Cate goricalValue{String, UInt8}, Union{}}}, LowRankModels.var"#147#148"{DataFrame, Int64}}) @ Base ./array.jl:678 [6] NaNs_to_Missing!(df::DataFrame) @ LowRankModels ~/JuliaEnvs/LowRankModels.jl/src/fit_dataframe.jl:281 [7] GLRM(df::DataFrame, k::Int64; losses::Vector{Loss}, rx::QuadReg, ry::QuadReg, offset::Bool, scale: :Bool, prob_scale::Bool, NaNs_to_Missing::Bool) @ LowRankModels ~/JuliaEnvs/LowRankModels.jl/src/fit_dataframe_w_type_imputation.jl:17 [8] GLRM(df::DataFrame, k::Int64) @ LowRankModels ~/JuliaEnvs/LowRankModels.jl/src/fit_dataframe_w_type_imputation.jl:15 [9] top-level scope @ ~/JuliaEnvs/LowRankModels.jl/examples/fit_rdataset.jl:9 [10] include(fname::String) @ Base.MainInclude ./client.jl:444 [11] top-level scope @ ~/JuliaEnvs/LowRankModels.jl/examples/runexamples.jl:17 [12] include(fname::String) @ Base.MainInclude ./client.jl:444 [13] top-level scope @ ~/JuliaEnvs/LowRankModels.jl/test/runtests.jl:34 [14] include(fname::String) @ Base.MainInclude ./client.jl:444 [15] top-level scope @ none:6 in expression starting at /Users/oxinabox/JuliaEnvs/LowRankModels.jl/examples/fit_rdataset.jl:9 in expression starting at /Users/oxinabox/JuliaEnvs/LowRankModels.jl/examples/runexamples.jl:17 in expression starting at /Users/oxinabox/JuliaEnvs/LowRankModels.jl/test/runtests.jl:34 ERROR: Package LowRankModels errored during testing
Looking at the code for NaNtoMissing it was a bit funky. I made it less funky.
NaNtoMissing
Now tests pass without errors for me
bump
running the tests was erroring with:
Looking at the code for
NaNtoMissing
it was a bit funky. I made it less funky.Now tests pass without errors for me