search

madeleineudell / LowRankModels.jl

LowRankModels.jl is a julia package for modeling and fitting generalized low rank models.
Other
190 stars 65 forks source link

initial implementation of nndsvd #22

Closed ahwillia closed 9 years ago

ahwillia commented 9 years ago

Here is a quick implementation of nndsvd.

We should probably develop a few test cases to make sure this is working as expected before merging. But it seems to be behaving reasonably in my hands so far...

madeleineudell commented 9 years ago

This looks good to me! (Though of course more tests would also be great.)

Also, it seems like the convention is to have a newline at the end of the file.