search

madeleineudell / LowRankModels.jl

LowRankModels.jl is a julia package for modeling and fitting generalized low rank models.
Other
190 stars 65 forks source link

Pull request/6ccc2fc9 #23

Closed ahwillia closed 9 years ago

ahwillia commented 9 years ago

hmm... accidentally created a new pull request, instead of pushing changes to the other one.

I'll delete this...

madeleineudell commented 9 years ago

If you just push to the same branch the changes should show up in the old PR.

On Mon, Jul 6, 2015 at 2:11 PM, Alex Williams notifications@github.com wrote:

Closed #23 https://github.com/madeleineudell/LowRankModels.jl/pull/23.

— Reply to this email directly or view it on GitHub https://github.com/madeleineudell/LowRankModels.jl/pull/23#event-349083085 .

Madeleine Udell www.stanford.edu/~udell

ahwillia commented 9 years ago

I think I've thoroughly confused myself by using (in julia):

Pkg.submit("LowRankModels")

Now in the shell:

$ git push origin nndsvd
ERROR: Permission to madeleineudell/LowRankModels.jl.git denied to ahwillia.
$ git push
fatal: The current branch nndsvd has no upstream branch.

Do I need to create a new remote for ahwillia/LowRankModels.jl?

madeleineudell commented 9 years ago

I think the nicest way to do PRs is to fork the repo and develop on your fork, then submit PRs to master when appropriate. I've never used Pkg.submit... So indeed, I would suggest that you create a new remote, ahwillia/LowRankModels.jl.

On Mon, Jul 6, 2015 at 2:31 PM, Alex Williams notifications@github.com wrote:

I think I've thoroughly confused myself by using (in julia):

Pkg.submit("LowRankModels")

Now in the shell:

$ git push origin nndsvd ERROR: Permission to madeleineudell/LowRankModels.jl.git denied to ahwillia.

$ git push fatal: The current branch nndsvd has no upstream branch.

Do I need to create a new remote for ahwillia/LowRankModels.jl?

— Reply to this email directly or view it on GitHub.

Madeleine Udell www.stanford.edu/~udell