madeleineudell / LowRankModels.jl

LowRankModels.jl is a julia package for modeling and fitting generalized low rank models.
Other
190 stars 65 forks source link

Detecting and dealing with Categorical Data #36

Open NandanaSengupta opened 9 years ago

NandanaSengupta commented 9 years ago

ISSUE 1: Currently when running glrm, labels = GLRM(df, k) on a dataset 'df' which has categorical variables, the GLRM is run ignoring these variables. The only way to figure out that this is happening from the User's end is checking length(labels).

DESIRED BEHAVIOR: A warning message informing the user that variables in df are being ignored and suggesting the use of the expand_categoricals( ) function.

ISSUE 2: Currently when running df2 = expand_categoricals(df, v) where df is a DataFrame and v is a vector with column indices, the command returns a Match error. It runs only after I run v = convert(Array, v)

DESIRED BEHAVIOR: Automatically converting the column indices vector to Array/ accepting vectors into the expand_categoricals( ) function.