madeleineudell / LowRankModels.jl

LowRankModels.jl is a julia package for modeling and fitting generalized low rank models.
Other
190 stars 65 forks source link

fix simplex evaluate to have a small tolerance #39

Closed ahwillia closed 9 years ago

ahwillia commented 9 years ago

At some point the evaluate function for simplex() was changed to check sum(a) == 1.0 rather than abs(sum(a)-1.0) < 1e-12... This is too strict, and causes the following bad behavior (fixed by this PR):

julia> using LowRankModels
julia> evaluate(simplex(),[1.0,0.0,0.0])
Inf