madeleineudell / LowRankModels.jl

LowRankModels.jl is a julia package for modeling and fitting generalized low rank models.
Other
190 stars 65 forks source link

extend observations to work on DataArrays in addition to DataFrames #44

Closed ahwillia closed 9 years ago

ahwillia commented 9 years ago

I've found DataFrames can be cumbersome to work with (especially when creating synthetic datasets to prototype models). I think the observations function should work with DataArrays as well.

madeleineudell commented 8 years ago

By the way this actually broke observations for DataFrames! I've updated the code; it's not very elegant but gets the job done.

ahwillia commented 8 years ago

Weird, sorry about that. Your fix looks good!